Fix: Add Block Icon Not Visible #11376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #11345 it is noted that the add block button does not appear visually to users when tabbing through blocks. The fix for me seemed to be adding a
:focusstate for the toggle button itself which sets the opacity of the bottom to 1, making it appear.It's possible that some class names changed which cause this as I did see a
.is-visibleclass reference. There is a parent Div node that does receive the class on focus. Hopefully someone knows the original implementation details and can speak to that.How has this been tested?
I opened edit post screen in Chrome, Safari, Firefox, IE11, and Edge. Then I tabbed backwards through several paragraph blocks. Each time the button appeared for me.
Screenshots
Types of changes
Bug fix
Checklist: