Add Transformation from Separator to Spacer #65492
Labels
[Block] Separator
Affects the Separator Block
[Block] Spacer
Affects the Spacer Block
Good First Issue
An issue that's suitable for someone looking to contribute for the first time
[Type] Enhancement
A suggestion for improvement.
Comments
skorasaurus
added
[Block] Separator
|
Hey, I would like to work on this issue. |
rudrakshi-gupta
pushed a commit
to rudrakshi-gupta/gutenberg
that referenced
this issue
Oct 18, 2024
talldan
added a commit
that referenced
this issue
Oct 24, 2024
* Add a transform from the Separator block to the Spacer block * Add a transform from the Separator block to the Spacer block Feat #65492 * Add transformation from spacer to separator - Remove the default height of 50px after transformation to default 100px that of Spacer - Update the transform of blocks so that it retains anchor attribute * Add new transformation block titles in Test * Add new transformation block titles in Test * Add new transformation block titles in Test and resolve linting problem * Add new transformation block titles in Test and resolve linting problem * Update test suite snapshot for test [mobile] to pass successfully --------- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: rudrakshi-gupta <rudrakshigupta@git.wordpress.org>
mtias
added
the
Good First Issue
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this issue
Nov 13, 2024
* Add a transform from the Separator block to the Spacer block * Add a transform from the Separator block to the Spacer block Feat WordPress#65492 * Add transformation from spacer to separator - Remove the default height of 50px after transformation to default 100px that of Spacer - Update the transform of blocks so that it retains anchor attribute * Add new transformation block titles in Test * Add new transformation block titles in Test * Add new transformation block titles in Test and resolve linting problem * Add new transformation block titles in Test and resolve linting problem * Update test suite snapshot for test [mobile] to pass successfully --------- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: rudrakshi-gupta <rudrakshigupta@git.wordpress.org>
|
Hey @mtias |
|
@Antrikshgwal I think this was already implemented in #66230. |
I think the confusion here stems from the fact that @rudrakshi-gupta commented here that he'd like to work on the issue, and submitted a PR to fix it 3 days later without explicitly tagging that the PR is intended to fix this issue. In the future, it would be great to do that so that a) this issue can get properly updated and tracked, and b) whoever first submitted the issue also gets props ;) Looking forward to having this transformation available on our sites - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this address?
We are still dealing with lots of old content being converted into the Block Editor, and as white space was hard to control in the Classic Editor, people have made liberal use of hr's, which get turned into separator blocks in the conversion process. It has become very commonplace for us to replace them with Separator blocks and just rely on whitespace for separation between content sections, which gives a much more modern look.
What is your proposed solution?
Add a transform from the Separator block to the Spacer block
The text was updated successfully, but these errors were encountered: