-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav block renderer error with markup for inner blocks #59814
Labels
[Block] Navigation
Affects the Navigation Block
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Comments
afragen
added a commit
to afragen/gutenberg
that referenced
this issue
Mar 13, 2024
Fixes get_markup_for_inner_block()
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this issue
Mar 27, 2024
…arkup_for_inner_block()` (WordPress#59820) * Fix for WordPress#59814 Fixes get_markup_for_inner_block() * fix WPCS issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Raising a complimentary Issue in Gutenberg repo for https://core.trac.wordpress.org/ticket/60762.
What follows is pasted from that Trac ticket:
class-wp-html-tag-processor.php on line 876 can have an null value passed to strlen() as $this->html resulting in a PHP8 error.
This seems to have originated from a change in WordPress/wordpress-develop@1f8bb9f#diff-1bea3165bce53d53ac51db1b623291fcd75ca59e08ec124df652312329160685L143-R169 where static::get_markup_for_inner_block( $inner_block ) can return null instead of an empty string.
If the function is changed from
to the following, this is mitigated.
The text was updated successfully, but these errors were encountered: