Add graceful support and more tests

WordPress · Mar 13, 2023 · 37cf182 · 37cf182
1 parent f69c57d
commit 37cf182
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/packages/core-data/src/utils/set-nested-value.js b/packages/core-data/src/utils/set-nested-value.js
@@ -15,6 +15,10 @@
  * @param {*}      value  Value to set.
  */
 export default function setNestedValue( object, path, value ) {
+	if ( ! object || typeof object !== 'object' ) {
+		return object;
+	}
+
 	path.reduce( ( acc, key, idx ) => {
 		if ( acc[ key ] === undefined ) {
 			if ( Number.isInteger( path[ idx + 1 ] ) ) {

diff --git a/packages/core-data/src/utils/test/set-nested-value.js b/packages/core-data/src/utils/test/set-nested-value.js
@@ -31,6 +31,12 @@ describe( 'setNestedValue', () => {
 		expect( result ).toEqual( { x: [ { z: 123 } ] } );
 	} );
 
+	it( 'should also work with arrays', () => {
+		const result = setNestedValue( [], [ 0, 1, 2 ], 123 );
+
+		expect( result ).toEqual( [ [ , [ , , 123 ] ] ] );
+	} );
+
 	it( 'should keep remaining properties unaffected', () => {
 		const input = { x: { y: { z: 123, z1: 'z1' }, y1: 'y1' }, x1: 'x1' };
 		const result = setNestedValue( input, [ 'x', 'y', 'z' ], 456 );
@@ -48,4 +54,19 @@ describe( 'setNestedValue', () => {
 		expect( result ).toBe( input );
 		expect( result ).toEqual( { x: 'z' } );
 	} );
+
+	it.each( [
+		undefined,
+		null,
+		0,
+		5,
+		NaN,
+		Infinity,
+		'test',
+		false,
+		true,
+		Symbol( 'foo' ),
+	] )( 'should return the original input if it is %s', ( value ) => {
+		expect( setNestedValue( value, [ 'x' ], 123 ) ).toBe( value );
+	} );
 } );