Fix race condition related to the measurement of PdfView
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like in some cases, Yoga (I think) will measure the view only along one axis first, resulting in
onSizeChanged
being called with either w or h set to zero. This in turn starts the rendering of the pdf under the hood with one dimension being set to zero and the follow-up call toonSizeChanged
with the correct dimensions doesn't have any effect on the already started process.The offending class is DecodingAsyncTask, which tries to get width and height of the
PdfView
in the constructor, and is created as soon as the measurement is complete (relevant lines here and here), which in some cases may be incomplete as described above.By delaying calling
super.onSizeChanged
until the size in both dimensions is correct we are able to prevent this from happening.