Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pause Icon is not loaded correctly for server with url-prefix #167

Open
Dencrash opened this issue Feb 28, 2025 · 0 comments
Open
Assignees
Labels
Bug Something isn't working as expected

Comments

@Dencrash
Copy link

Describe the bug
When running a foundry server behind a URL prefix, the pause button is not displayed correctly.

To Reproduce

  1. Setup server with URL Prefix
  2. Start a game world
  3. See in the Network Tab that the URL is called without a Prefix

Expected behavior
The call should be made with the system prefix in mind and the pause button should be displayed

User Information

  • Browser:
  • FoundryVTT Version: Version 12 Stable
  • World of Darkness 5e system Version: 5.0.11

Additional context
The bug is similar to the previous issue here #118
However, the pause icon isn't referenced in the styling but directly in .js which is why the fix did not work
I hotfixed it in my system by adjusting the code system/ui/pause.js to:

<img class="fa-spin pause-border" src="systems/vtm5e/assets/ui/Pause_Border.webp"> <img class="pause-overlay" src="systems/vtm5e/assets/ui/Pause_Overlay.webp">

@Veilza Veilza added the Bug Something isn't working as expected label Mar 1, 2025
@Veilza Veilza self-assigned this Mar 1, 2025
@Veilza Veilza moved this to To-do in 5.1.0 Release Mar 1, 2025
Veilza added a commit that referenced this issue Mar 1, 2025
@Veilza Veilza moved this from To-do to Pending Merge in 5.1.0 Release Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as expected
Projects
Status: Pending Merge
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants