Window mode fix #51
Merged
Window mode fix #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizzardMaker
force-pushed
the
develop
branch
3 times, most recently
from
5523803 to
ae4ff4e
Compare
The windowed mode used only the default value of 640 480 every time also on startup. Changed to used maximum window size and centered on screen with SDL constants
The Options were extended to save also the last set Width and Height of the window. The UpdateWindow function was modified to use this setting if it is set. When changing the view in options to windowed its reseted to a maximized window, by setting the default window size of 640x480.
WizzardMaker
force-pushed
the
window_mode_fix
branch
from
7d3696c to
f775aa2
Compare
|
Rebased to the latest HEAD of develop Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Options were extended to save the last set Width and Height of the window. The UpdateWindow function was modified to use this setting if it is set. When changing the view in options from fullscreen or borderless to windowed it reset to a maximized window, by setting the default window size of 640x480. This will trigger the UpdateWindow function to set it to maximized.
Also, the position was changed to use SDL_WINDOWPOS_CENTERED instead of a calculation.