Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

113-improve image count query performance, add a spinner to indicate loading #125

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Dec 3, 2024

  1. by reducing database queries, the time required to query image count is effectively reduced. It used to take 28 seconds to query 70,000 images and 20,000+ annotations, now it only takes 2-3 seconds.

  2. add a spinner to indicate loading status

PR fixes #113

Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner (and the spinner is a great touch)

@TanyaStere42 TanyaStere42 merged commit 3bdaa9e into main Dec 4, 2024
@TanyaStere42 TanyaStere42 deleted the 113_WIC_score_filtering branch December 4, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image selection with WIC scores lags and it's difficult to know if it is selecting correctly
2 participants