Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60 filter image by datetime #124

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Nov 27, 2024

update startdate and enddate component to enable filter images by both date and time.

PR fixes #60

Notes:
couldn't do a very detailed test on filtering by exact time because all exifTampStamp in my dev is 0 and changes to db will lose after docker restart

@erinz2020 erinz2020 self-assigned this Nov 27, 2024
@TanyaStere42
Copy link
Member

@naknomum can you test this? I also have no timestamp info

@TanyaStere42 TanyaStere42 requested a review from naknomum December 2, 2024 17:00
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, default behavior is great for no-timestamp filtering

@naknomum
Copy link
Member

naknomum commented Dec 2, 2024

@naknomum can you test this? I also have no timestamp info

yes, will test this branch with some date-stamped images today.

@erinz2020
Copy link
Contributor Author

@TanyaStere42 now scout on QA has datetime data to test this pr, I tested and it was good, if you want to have a look you can test with 2024-12-03 15:23 and 2024-12-03 15:25, different image counts will be returned

@TanyaStere42 TanyaStere42 merged commit 90d18e0 into main Dec 3, 2024
@TanyaStere42 TanyaStere42 deleted the 60_filter_image_by_datetime branch December 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New Task - Filter Images by datetime
3 participants