Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

109 annotations box outlines #119

Merged
merged 3 commits into from
Nov 22, 2024
Merged

109 annotations box outlines #119

merged 3 commits into from
Nov 22, 2024

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Nov 22, 2024 •
edited by TanyaStere42
Loading

  1. remove the red color fill from all the bounding boxes so the color won't cover the animals
  2. add 2 px red border to the boxes
  3. hover color remains unchanged

PR fixes #120

@erinz2020 erinz2020 self-assigned this Nov 22, 2024
@TanyaStere42 TanyaStere42 linked an issue Nov 22, 2024 that may be closed by this pull request
Making the bounding boxes thin red lines with _no fill_ would also make it easier to see what's inside the box. This could be toggled, or maybe just become a default? #120
Closed
TanyaStere42
TanyaStere42 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean changes. updated to address #120 instead as #109 issues are only partially reviewed, but this is a great start it improving the visibility during annotation

@TanyaStere42 TanyaStere42 merged commit cea40ba into main Nov 22, 2024
@TanyaStere42 TanyaStere42 deleted the 109_annotations_box_outlines branch November 22, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaStere42 TanyaStere42 TanyaStere42 approved these changes

Assignees

@erinz2020 erinz2020

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erinz2020 @TanyaStere42