Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add toggle for set/unset active hotkey #117

Merged
merged 4 commits into from
Nov 25, 2024
Merged

add toggle for set/unset active hotkey #117

merged 4 commits into from
Nov 25, 2024

Conversation

erinz2020
Copy link
Contributor

add a switch on annotation and ground truth page,

  1. if it's off, no active key
  2. toggle is automatically turned on when a label hotkey is selected

PR fixes #110

@erinz2020 erinz2020 marked this pull request as ready for review November 22, 2024 01:01
@erinz2020 erinz2020 self-assigned this Nov 22, 2024
TanyaStere42
TanyaStere42 requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, leverage 'switch' instead of 'checkbox'. clarifies functional intent

@erinz2020
Copy link
Contributor Author

if possible, leverage 'switch' instead of 'checkbox'. clarifies functional intent

updated

TanyaStere42
TanyaStere42 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@TanyaStere42 TanyaStere42 merged commit 06ee496 into main Nov 25, 2024
@TanyaStere42 TanyaStere42 deleted the 110_toggle_current_hotkey branch November 25, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaStere42 TanyaStere42 TanyaStere42 approved these changes

Assignees

@erinz2020 erinz2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a button or another key to press to **unset the current species hotkey**
2 participants
@erinz2020 @TanyaStere42