Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

916 header quick search #998

Merged
merged 14 commits into from
Feb 4, 2025
Merged

916 header quick search #998

merged 14 commits into from
Feb 4, 2025

Conversation

erinz2020
Copy link
Contributor

@erinz2020 erinz2020 commented Jan 28, 2025

bring header search back in header. if logged in, user can search individuals by typing individual names and ids.

  • Header has a quick search that you make active by clicking
  • type to search on individual names and ids
  • first 10 search results will be displayed
  • if no results, displays No matching results
  • spinner displays during search
  • has a link to individual page
  • Header updated for react and jsp. html form not included.

@erinz2020 erinz2020 self-assigned this Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 0.13%. Comparing base (de024d5) to head (96d4d1e).

Files with missing lines Patch % Lines
...ontend/src/components/header/HeaderQuickSearch.jsx 0.00% 23 Missing ⚠️
frontend/src/models/usePostHeaderQuickSearch.js 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main    #998      +/-   ##
==========================================
- Coverage     0.13%   0.13%   -0.01%     
  Complexity      29      29              
==========================================
  Files          578     580       +2     
  Lines        63976   64015      +39     
  Branches     11084   11090       +6     
==========================================
  Hits            89      89              
- Misses       63868   63907      +39     
  Partials        19      19              
Flag Coverage Δ
backend 0.13% <0.00%> (-0.01%) ⬇️
frontend 0.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erinz2020 erinz2020 requested a review from naknomum February 3, 2025 21:52
@erinz2020 erinz2020 marked this pull request as ready for review February 3, 2025 21:52
@erinz2020 erinz2020 force-pushed the 916_header_quick_search branch from 8ae19d9 to 96d4d1e Compare February 3, 2025 23:49
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@naknomum naknomum merged commit bc71c9f into main Feb 4, 2025
1 check passed
@naknomum naknomum deleted the 916_header_quick_search branch February 4, 2025 01:07
@erinz2020 erinz2020 mentioned this pull request Feb 11, 2025
@erinz2020 erinz2020 linked an issue Feb 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

header quick search
3 participants