removes redundant database close that will otherwise happen anyway in … #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the finaly{} block, even if the return is called.
|
@naknomum is there a reason this didn't get merged when it was approved? |
no - i just got on a small CR spree yesterday and approved some PRs but never merged. my bad. |
holmbergius
added a commit
that referenced
this pull request
Jan 3, 2025
…xing removes redundant database close that will otherwise happen anyway in …
holmbergius
added a commit
that referenced
this pull request
Jan 8, 2025
…xing removes redundant database close that will otherwise happen anyway in …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the finaly{} block, even if the return is called.
An exception can be thrown due to a database close in the try{} block and then again in the finally{} block. This removes the redundant database close, trusting the finally{} to handle the close, even with the return; out of the function..