Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Encounter single submission multi-algorithm, cloneEncounter bug #853

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

JasonWildMe
Copy link
Contributor

Fixes the situation where Encounter cloning (>1 animal in photo) and multi-algorithm matching cause only one algorithm's results to be shown rather than all algorithms.

PR fixes #632

Changes

  • Switch IBEISIA to use Encounter-based annotation submission to the matching queue. previously it was all annotations across the original and cloned Encounter.

@JasonWildMe JasonWildMe requested a review from naknomum October 29, 2024 20:57
@JasonWildMe JasonWildMe self-assigned this Oct 29, 2024
@JasonWildMe
Copy link
Contributor Author

JasonWildMe commented Oct 29, 2024

Testing passed. Tested conditions:

  • one animal, one algorithm
  • one animal, two algorithms
  • two animals in photo, one algorithm
  • two animals, two algorithms

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@naknomum naknomum merged commit 7b79103 into main Oct 29, 2024
@naknomum naknomum deleted the issue-632-2 branch October 29, 2024 22:27
@TanyaStere42 TanyaStere42 linked an issue Oct 30, 2024 that may be closed by this pull request
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
Fix Encounter single submission multi-algorithm, cloneEncounter bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants