[795] information frame #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinz2020
reviewed
Oct 11, 2024
There was a problem hiding this comment.
hi Pavan can you add a state in the store to control the display of *? so that we can centralizes validation logic and ensures that UI updates reactively based on state changes, making the code more maintainable and consistent, thanks
btw, I have merged #831 and now there are some conflicts between your two PRs, do you mind rebase submission_page and fix the conflicts before I can merge this PR? Thanks again
PAVANA809
force-pushed
the
795_information_frame
branch
from
51c9b32 to
9141652
Compare
|
hi Pavan, do you mind applying the state "required" in the species component, in the two places we we display the star sign? for example, |
Rodhlann
pushed a commit
to Rodhlann/Wildbook
that referenced
this pull request
Dec 6, 2024
[795] information frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes: #795
added followup information frame and email validation