Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo update #725

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Logo update #725

merged 2 commits into from
Sep 4, 2024

Conversation

TanyaStere42
Copy link
Member

Cleaning up outdated logo references and found a css typo across a couple pages

PR does not fix a named issue

@TanyaStere42 TanyaStere42 added the techdebt work that needs to be done to clean things up label Sep 3, 2024
@TanyaStere42 TanyaStere42 changed the base branch from master to dev10.4 September 3, 2024 23:11
@TanyaStere42 TanyaStere42 self-assigned this Sep 3, 2024
@naknomum
Copy link
Member

naknomum commented Sep 4, 2024

the only comment/question i have is do we care that the new image referenced is gigantic? that is, it is replacing a small one in html that has width=50 and similar small values. sure it will be cached, so we only get hit once with the (minor!) network overhead. but thought i should mention it.

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@naknomum naknomum merged commit f56b7b2 into dev10.4 Sep 4, 2024
1 check passed
@naknomum naknomum deleted the logo-update branch September 4, 2024 22:21
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
techdebt work that needs to be done to clean things up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants