Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react][readme] Update instruction ports to match defaults, clarify PUBLIC_URL #718

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

carllelandtaylor
Copy link
Contributor

I'm getting the basic dev environment set up and have a couple fixes/suggestions for the React readme. Please let me know if I've gotten anything wrong, of course.

Changes

  • Fix the port number in the instructions to match the default and the devops readme.
  • Clarify that the .env file is for React environment variables, and when you use which value for PUBLIC_URL.

Copy link
Contributor

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erinz2020 erinz2020 merged commit f0dbbb5 into WildMeOrg:master Sep 3, 2024
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
…-update

[react][readme] Update instruction ports to match defaults, clarify PUBLIC_URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants