622: remove youtube agent code #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -306,71 +306,7 @@ public static void executeEmails(Shepherd myShepherd, HttpServletRequest request | |||
| } | |||
|
|
|||
| private void youTubePostback(Encounter enc2add, Shepherd myShepherd, String context) { | |||
There was a problem hiding this comment.
why is this being maintained? couldn't we remove all of youTubePostback?
There was a problem hiding this comment.
removed this, as well as stuff in webapp/WEB-INF/data. i did leave these, as they were the only files without sutime in their names, but likely they can go too. am i 100% sure? no. but close. so i left them.
$ ls -lt src/main/webapp/WEB-INF/data/english-left3words-distsim.tagger*
-rw-rw-r-- 1 jon jon 12409329 Jul 29 16:00 src/main/webapp/WEB-INF/data/english-left3words-distsim.tagger
-rw-rw-r-- 1 jon jon 1522 Jul 29 16:00 src/main/webapp/WEB-INF/data/english-left3words-distsim.tagger.props
TanyaStere42
approved these changes
Aug 29, 2024
Rodhlann
pushed a commit
to Rodhlann/Wildbook
that referenced
this pull request
Dec 6, 2024
622: remove youtube agent code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes #622
Notably,
YouTubeAssetStoreis left intact, so that historical data derived from YouTube is still accessible and usable.This can be addressed later, for example, by "migrating" to standard LocalAssetStore.