Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent login from overriding session timeout defined in web.xml #695

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

holmbergius
Copy link
Contributor

Login.java defined a long session timeout that overrides the default in web.xml. This commit removes the single line of code that restores the default, expected timeout.

PR fixes #690

Changes

  • Removes code line overriding default session timeout

Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yepyep

@holmbergius holmbergius requested a review from naknomum August 26, 2024 17:15
@TanyaStere42 TanyaStere42 merged commit 42a7eb9 into master Aug 26, 2024
1 check passed
@TanyaStere42 TanyaStere42 deleted the 690-restore-timeout-default branch August 26, 2024 17:16
holmbergius pushed a commit that referenced this pull request Sep 24, 2024
Prevent login from overriding session timeout defined in web.xml
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
…efault

Prevent login from overriding session timeout defined in web.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing session timeout warnings
2 participants