Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce annot comparison time between Wildbook and WBIA by caching #666

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

holmbergius
Copy link
Contributor

Wildbook is comparing lists of annotations with WBIA on building every ID job. This is excessive, and even if they are out of sync, Wildbook sends the small difference after checking. Using caching, this comparison process is sped up 95%, allowing Wildbook to send ID jobs to WBIA much more quickly and reducing request traffic to WBIA that is competing with actual ID job execution for resources.

Changes

  • adds a cache to the sendAnnotationsAsNeeded process during ID job creation.

@holmbergius holmbergius marked this pull request as ready for review August 10, 2024 17:25
@holmbergius holmbergius requested a review from naknomum August 15, 2024 18:07
@holmbergius holmbergius self-assigned this Aug 15, 2024
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@naknomum naknomum merged commit 251645a into master Aug 16, 2024
1 check passed
@naknomum naknomum deleted the cache-ia-annots-ids-check branch August 16, 2024 21:55
@TanyaStere42 TanyaStere42 added this to the 10.3.0 milestone Aug 20, 2024
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
…heck

Reduce annot comparison time between Wildbook and WBIA by caching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants