Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken calls to getHTMLSelector() #631

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Jul 2, 2024

a change to LocationID.java introduced a new variation of the method getHTMLSelector() which created ambiguous call from a few jsp pages. these were fixed by casting null to a string.

@naknomum naknomum changed the title fix submit.jsp fix broken calls to getHTMLSelector() Jul 2, 2024
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that'll do it 👍

@TanyaStere42 TanyaStere42 merged commit 815a19f into master Jul 2, 2024
2 checks passed
@TanyaStere42 TanyaStere42 deleted the submit-jsp-fix branch July 2, 2024 21:13
@TanyaStere42 TanyaStere42 added this to the 10.3.0 milestone Aug 20, 2024
@TanyaStere42 TanyaStere42 added the bug something's broken! label Aug 20, 2024
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
fix broken calls to getHTMLSelector()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something's broken!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants