582 stonely widget in react header #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naknomum
reviewed
Jun 12, 2024
frontend/src/GoogleTagManager.jsx
Outdated
| const gtmKey = window.wildbookGlobals.gtmKey || "changeme"; | ||
|
|
||
| loadScript( | ||
| "https://www.googletagmanager.com/gtag/js?id=UA-30944767-7", |
There was a problem hiding this comment.
do we know where this id=VALUE comes from? feels very hard-coded. is this from some kind of wild me dashboard or something? feels like it should be coming from a config setting as well. maybe @holmbergius knows something of this?
naknomum
requested changes
Jun 12, 2024
turned this ga_id to a variable in properties file |
Rodhlann
pushed a commit
to Rodhlann/Wildbook
that referenced
this pull request
Dec 6, 2024
…_react_header 582 stonely widget in react header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #582
add stonely widget to react pages head