#578consistent header and footer #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erinz2020 can you add "fixes #578 and fixes #579" in your PR description so this links to those issues? |
This was
linked to
issues
Jun 10, 2024
naknomum
reviewed
Jun 11, 2024
| notifications = Collaboration.getNotificationsWidgetHtml(request, myShepherd); | ||
| if (request.getUserPrincipal() != null && !loggingOut) { | ||
| user = myShepherd.getUser(request); | ||
| username = (user != null) ? user.getUsername() : null; |
There was a problem hiding this comment.
might be best to wrap this whole section in if (user != null) { .... rather than test for username separately, since we also should have one for the line below: if (user.getUserImage()...) is not checking for null user.
naknomum
requested changes
Jun 11, 2024
ignoring this since we are moving beyond this. |
Rodhlann
pushed a commit
to Rodhlann/Wildbook
that referenced
this pull request
Dec 6, 2024
#578consistent header and footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578 and #579