Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 756 merge individual automation and notification fixes #1002

Merged
merged 6 commits into from
Feb 22, 2025

Conversation

holmbergius
Copy link
Contributor

[Plain-text summary description of the solution. Include any class updates, new or edited functions, significant changes to UX, etc]

PR fixes #756

Before you Submit!

  • Is all the text internationalized?
  • If you made a change to the header, did you update the react, jsp, and html?
  • Are all depedencies at a locked version?
  • Did you adhere to best practices?
  • Is there a quick unit test you can add?

@holmbergius holmbergius marked this pull request as ready for review February 3, 2025 04:43
@holmbergius holmbergius requested a review from naknomum February 3, 2025 04:43
@holmbergius holmbergius self-assigned this Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 0.14%. Comparing base (fbac158) to head (38e85ef).
Report is 159 commits behind head on main.

Files with missing lines Patch % Lines
...rg/ecocean/scheduled/ScheduledIndividualMerge.java 0.00% 23 Missing ⚠️
frontend/src/components/navBar/MergeMessages.jsx 0.00% 8 Missing ⚠️
...models/notifications/changeIndividualMergeState.js 0.00% 7 Missing ⚠️
...main/java/org/ecocean/servlet/MergeIndividual.java 0.00% 7 Missing ⚠️
...java/org/ecocean/servlet/UserGetNotifications.java 0.00% 6 Missing ⚠️
src/main/java/org/ecocean/MarkedIndividual.java 0.00% 3 Missing ⚠️
src/main/java/org/ecocean/StartupWildbook.java 0.00% 3 Missing ⚠️
.../main/java/org/ecocean/security/Collaboration.java 0.00% 3 Missing ⚠️
...cocean/servlet/ScheduledIndividualMergeUpdate.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #1002      +/-   ##
==========================================
- Coverage     0.14%   0.14%   -0.01%     
  Complexity      29      29              
==========================================
  Files          565     565              
  Lines        63188   63211      +23     
  Branches     10947   10950       +3     
==========================================
  Hits            89      89              
- Misses       63080   63103      +23     
  Partials        19      19              
Flag Coverage Δ
backend 0.14% <0.00%> (-0.01%) ⬇️
frontend 0.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@naknomum naknomum merged commit bef6e05 into main Feb 22, 2025
1 check passed
@naknomum naknomum deleted the issue-756-merge-individual branch February 22, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge request response saved in session but not in database
4 participants