Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pickups): Added pickups and pickup spawning #8

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

finger563
Copy link
Member

@finger563 finger563 commented Jan 22, 2025

Description

  • Updated BPI_Interaction so that the interaction returns a bool
  • Updated affected classes which implement interaction so that they return bools (grid, ufgchar_base, bigmoss)
  • Added Pickup_BASE and AutoPickup_BASE for the types of actors which are the pickup variants
  • Updated inventory to fix issue with number of items added being the total number of items of that type

Motivation and Context

Closes #6
Closes #4

How has this been tested?

Ran in editor and ensured that:

  • NPC interaction still works with both NPCs
  • BigMoss can still be placed and rotated, and its spawned item is generated but must be manually picked up
  • Growable_BASE can still be placed, and its spawned item is automatically picked up when the player comes in range

Screenshots (if appropriate):

Little moss / automatic pickups:

auto-pickup-test-compressed.mp4

Big moss / rotation / manual pickups:

pickup-test-compressed.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Art / Asset
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Art / Asset Update
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Updated BPI_Interaction so that the interaction returns a bool
* Updated affected classes which implement interaction so that they return bools (grid, ufgchar_base, bigmoss)
* Added Pickup_BASE and AutoPickup_BASE for the types of actors which are the pickup variants
* Updated inventory to fix issue with number of items added being the total number of items of that type

Closes #6
Closes #4

Ran in editor and ensured that:
- [x] NPC interaction still works with both NPCs
- [x] BigMoss can still be placed and rotated, and its spawned item is generated but must be manually picked up
- [x] Growable_BASE can still be placed, and its spawned item is automatically picked up when the player comes in range
@finger563 finger563 self-assigned this Jan 22, 2025
@finger563 finger563 merged commit d9cd36d into main Jan 22, 2025
@finger563 finger563 deleted the feat/4-6-pickup-actor-automatic-pickup branch January 24, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant