Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/grid improvement #40

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Feat/grid improvement #40

merged 2 commits into from
Feb 5, 2025

Conversation

finger563
Copy link
Member

Description

  • Move code to place item into inventory into the base of the grid item, so that simply calling interact on it will do the same work
  • Simplify the grid interaction code some, prep for future refactor / simplification
  • Add actual classes for pickups instead of just using the bases for moss / bigmoss
  • Add non-grid placed items into level for interaction
  • Update grid item to have interaction box, which is set to either item size or the grid size (if it is in a grid) - implement the placed in grid event handler to update the size
  • Update data table accordingly for new pickup items

Motivation and Context

Starts on the refactor for how we handle interaction and starts to allow growables / foragables / interactibles to existing in the world without being in a grid.

How has this been tested?

PIE and tested all grid systems work, as well as non-grid items.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Art / Asset
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Art / Asset Update
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Move code to place item into inventory into the base of the grid item, so that simply calling interact on it will do the same work
* Simplify the grid interaction code some, prep for future refactor / simplification
* Add actual classes for pickups instead of just using the bases for moss / bigmoss
* Add non-grid placed items into level for interaction
* Update grid item to have interaction box, which is set to either item size or the grid size (if it is in a grid) - implement the placed in grid event handler to update the size
* Update data table accordingly for new pickup items

Starts on the refactor for how we handle interaction and starts to allow growables / foragables / interactibles to existing in the world without being in a grid.

PIE and tested all grid systems work, as well as non-grid items.
@finger563 finger563 self-assigned this Feb 5, 2025
@finger563 finger563 merged commit 55ed63b into main Feb 5, 2025
@finger563 finger563 deleted the feat/grid-improvement branch February 5, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant