Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(player): Update so spring arm changes update point light etc #28

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

finger563
Copy link
Member

@finger563 finger563 commented Feb 1, 2025

Description

  • Update so that the point light can be updated via function
  • Update so scale setting is called with scale 1 on begin play - which ensures depth of field etc. are correct for the configured spring arm
  • Update so point light is configured properly on begin play
  • Update to have HeroLightOffsetFromPlayer FVector member on player to allow easy adjustment of hero light in editor; update to call UpdateHeroLight in construct script so that you can use the BP_Player's viewport to easily adjust the offset

Motivation and Context

Previously, if you changed the springarm target length, you'd have to manually adjust the focal length of the depth of field settings in the post process volume and you'd have to adjust the position of the pointlight.

This PR updates it so that those are automatically configured properly by the player in begin play, and continue to be updated properly if the player scale changes.

How has this been tested?

PIE and by adjusting scale

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Art / Asset
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Art / Asset Update
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update so that the point light can be updated via function
* Update so scale setting is called with scale 1 on begin play - which ensures depth of field etc. are correct for the configured spring arm
* Update so point light is configured properly on begin play
@finger563 finger563 self-assigned this Feb 1, 2025
@finger563 finger563 added enhancement New feature or request player character labels Feb 1, 2025
…allow easy adjustment of hero light in editor; update to call updateherolight in construct script
@finger563 finger563 merged commit fc85b8b into main Feb 1, 2025
@finger563 finger563 deleted the feat/player-springarm-update branch February 1, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request player character
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant