Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add type annotations to notifications #14058

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

nijel
Copy link
Member

@nijel nijel commented Feb 28, 2025

Also fixes some of the unhandled conditions.

@nijel nijel added this to the 5.11 milestone Feb 28, 2025
@nijel nijel self-assigned this Feb 28, 2025
@nijel nijel modified the milestones: 5.11, 5.10.3 Feb 28, 2025
Also fixes some of the unhandled conditions.
@nijel nijel enabled auto-merge (rebase) February 28, 2025 12:12
@nijel nijel disabled auto-merge February 28, 2025 12:13
@nijel nijel merged commit e6d788f into WeblateOrg:main Feb 28, 2025
44 checks passed
@nijel nijel deleted the notify-types branch February 28, 2025 12:13
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.99%. Comparing base (ca82ccc) to head (cb51115).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
weblate/accounts/notifications.py 68.42% 2 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14058      +/-   ##
==========================================
- Coverage   91.00%   90.99%   -0.01%     
==========================================
  Files         608      608              
  Lines       63648    63654       +6     
  Branches     6584     6587       +3     
==========================================
+ Hits        57923    57924       +1     
- Misses       4031     4033       +2     
- Partials     1694     1697       +3     
Files with missing lines Coverage Δ
weblate/auth/models.py 92.03% <100.00%> (ø)
weblate/accounts/notifications.py 94.07% <68.42%> (-0.93%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant