Add edge case tests for cmpxchg #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! Please join the W3C Community Group before contributing: it provides the legal framework that protects the work in this repository. |
While implementing wasm-threading in JavaScriptCore, we found that this edge cases are not tested in spec-tests. To clarify cmpxchg behavior, this patch adds them to spec-tests.
Constellation
force-pushed
the
cmpxchg
branch
from
010f1bf to
1dcbeac
Compare
|
@dschuff Thanks! I've just joined :) (yusukesuzuki / ysuzuki@apple.com). |
|
Friendly ping :) |
|
@dschuff Can you take a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing wasm-threading in JavaScriptCore, we found that this edge cases are not tested in spec-tests.
To clarify cmpxchg behavior, this patch adds them to spec-tests.