add register() method to base class #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We simply return a 400 if the user is already registered, so testing does not hit the live API. Instead, we mock the call. |
sam-watttime
commented
Dec 22, 2023
| def test_get_historical_csv(self): | ||
| start = parse("2022-01-01 00:00Z") | ||
| end = parse("2022-01-02 00:00Z") | ||
| self.historical.get_historical_csv(start, end, REGION) | ||
|
|
||
| fp = Path.home() / "watttime_historical_csvs" / f"{REGION}_co2_moer_{start.date()}_{end.date()}.csv" | ||
| fp = ( |
nsteins
reviewed
Dec 22, 2023
| @@ -1,7 +1,7 @@ | |||
| # About | |||
| This SDK is meant to help users with basic queries to WattTime’s API (version 3), and to get data returned in specific formats (e.g., JSON, pandas, csv). | |||
|
|
|||
| Users must first [register for access to the WattTime API here](https://watttime.org/docs-dev/data-plans/). | |||
| Users may register for access to the WattTime API through this client, however the basic user scoping given will only allow newly registered users to access data for the `CAISO_NORTH` region. Additionally, data may not be available for all signal types for newly registered users. | |||
There was a problem hiding this comment.
Do we still have an index datatype? or is CAISO_NORTH the only free thing in the new API?
There was a problem hiding this comment.
Still tbd afaik. Index is not implemented on v3 yet, and unclear if it will be.
nsteins
reviewed
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.