Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(apple): FFI and macOS+iOS build script #672

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

EbrahimTahernejad
Copy link
Contributor

@EbrahimTahernejad EbrahimTahernejad commented Jan 14, 2025

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

💡 Background and solution

This is an FFI plus a macOS and iOS build script.
Nothing much to say about it

📝 Changelog

  • FFI Crate
  • macOS and iOS build script

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: Ebrahim Tahernejad <ebrahimtahernejad@gmail.com>
Signed-off-by: Ebrahim Tahernejad <ebrahimtahernejad@gmail.com>
@hsqStephenZhang
Copy link

cool

@EbrahimTahernejad
Copy link
Contributor Author

EbrahimTahernejad commented Jan 15, 2025

Also an example workflow to craete a framework

https://github.com/EbrahimTahernejad/LibClashRsApple/blob/main/.github/workflows/Release.yml

ibigbug
ibigbug previously approved these changes Jan 16, 2025
Copy link
Member

@ibigbug ibigbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@EbrahimTahernejad
Copy link
Contributor Author

@ibigbug Can you review it again?

@ibigbug ibigbug merged commit 8649541 into Watfaq:master Jan 16, 2025
0 of 27 checks passed
@EbrahimTahernejad EbrahimTahernejad deleted the ios branch January 16, 2025 15:49
lakako pushed a commit to lakako/clash-rs that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants