Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sprite sheet #2489

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Fix sprite sheet #2489

merged 4 commits into from
Dec 1, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Nov 8, 2022

Update sprite sheet

Banner

  • Split banner into banner.svg
  • Copied hex codes by dropper on original sprite banner
  • banner.png Rendered at 700x10

Logos

  • Greatly improves the quality of the footer logos,
  • Using current versions of social icons
  • sprites.svg original vector art
    • Includes guides for spacing
  • sprites.png rendered to 768x128
    • Each logo is rendered at 128x128
    • Downres nicely to final 32x32 icon size

CSS

  • Fixed old background-position:-80px -350px; randomness
  • Now: background-position:-{{ 32xN }}px 0;

Results

aapb-sprites-before-after

Closes #2426

@mrharpo mrharpo requested a review from afred November 8, 2022 23:04
@mrharpo mrharpo self-assigned this Nov 8, 2022
afred
afred approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 4b43cd0 into master Dec 1, 2022
@afred afred deleted the MLAAAPB-49-sprite-sheet branch December 1, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sprite sheet cleanup
2 participants
@mrharpo @afred