Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Transcript/Caption Snippets Asynchronously #2400

Merged
merged 28 commits into from
Mar 21, 2022
Merged

Load Transcript/Caption Snippets Asynchronously #2400

merged 28 commits into from
Mar 21, 2022

Conversation

foglabs
Copy link
Contributor

@foglabs foglabs commented Mar 2, 2022

No description provided.

foglabs added 26 commits February 25, 2022 09:34
@foglabs
'wip'
688f04d
@foglabs
'more wip'
b14c53a
@foglabs
'wip it good'
a7898e6
@foglabs
'move snippet view helpers to correct scope'
3f0c75b
@foglabs
Merge branch 'master' into ajax-snippets
2bfafe6
@foglabs
'one request'
3262a7f
@foglabs
'add back default heights'
eb6e250
@foglabs
'the whims of rubo'
40b6b0f
@foglabs
'mo roo bow'
6ddd0fc
@foglabs
'only do full page fill if were not on page 1'
73c6a19
@foglabs
'rubo'
730870e
@foglabs
'debug'
f6f13bf
@foglabs
'block snippets for only invalid match found in text'
7dedfe5
@foglabs
'logging caption and transcript http requests'
9258dce
@foglabs
'update capfile and tfile tests, update references to classes through…
391f298 
…out'
@foglabs
'fix missing method in cap and tfile tests'
7b2bd93
@foglabs
'fix tests'
98bc736
@foglabs
'fix mock in pb spec and wrong method in pbcp'
566b6db
@foglabs
'we cant forget about the rubo'
2d937a7
@foglabs
'missing default arg in ts snippet'
1ee2b60
@foglabs
'add snippet view helper tests'
3910f10
@foglabs
'add external file spec'
746fbe3
@foglabs
'rubo'
d33589d
@foglabs
'force head check during ingest because cache isnt running'
a52caef
@foglabs
'oh rubo'
a112c87
@foglabs
'cleanup'
db53579
afred
afred approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 reviewed w/ @foglabs over pair up

@foglabs foglabs merged commit 9a3f706 into master Mar 21, 2022
@foglabs foglabs deleted the ajax-snippets branch March 21, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foglabs @afred