MARXAN-1274-publish-project-data #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
great 😃
I must confess I am not fully sold on splitting up document-like content across several JSONB columns (I would have used a single JSONB column and stuffed all the stuff in there, combining the specific types), but your proposed solution should work perfectly in any case, and given that we don't expect much of a change in these data structures, it should also make the implementation simpler (especially for partial updates where only some fields are populated).
Let's merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Adds new columns to publish project entity.
-Adapts tests to test if new data is included.
-Changes how tests are published by including a DTO.