Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/marxan 1452 set up volume for cloning files storage #997

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/api.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ COPY --chown=$USER:$USER nodemon.json tsconfig.json tsconfig.build.json nest-cli
COPY --chown=$USER:$USER apps ./apps
COPY --chown=$USER:$USER libs ./libs

RUN mkdir -p /opt/marxan-project-cloning
RUN chown -R $USER:$USER /opt/marxan-project-cloning

RUN yarn prestart:prod

EXPOSE 3000
Expand Down
3 changes: 3 additions & 0 deletions api/apps/api/config/custom-environment-variables.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@
"sharedFileStorage": {
"localPath": "API_SHARED_FILE_STORAGE_LOCAL_PATH",
"cleanupTemporaryFolders": "BACKEND_CLEANUP_TEMPORARY_FOLDERS"
},
"cloningFileStorage": {
"localPath": "CLONING_FILE_STORAGE_LOCAL_PATH"
}
},
"marxan": {
Expand Down
13 changes: 6 additions & 7 deletions api/apps/api/config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,15 @@
},
"network": {
"cors": {
"origins": [
"http://localhost:3010"
]
"origins": ["http://localhost:3010"]
}
},
"redis": {
"host": "marxan-redis",
"port": 6379,
"password": null,
"useTLS": false,
"concurrency" : 50
"concurrency": 50
},
"postgresApi": {
"url": null,
Expand Down Expand Up @@ -60,6 +58,9 @@
"storage": {
"sharedFileStorage": {
"localPath": "/tmp/storage"
},
"cloningFileStorage": {
"localPath": "/opt/marxan-project-cloning"
}
},
"marxan": {
Expand All @@ -77,8 +78,7 @@
}
},
"fileUploads": {
"limits": {
}
"limits": {}
},
"sparkpost": {
"apikey": "invalidSparkpostApikey",
Expand All @@ -95,4 +95,3 @@
"tokenPrefix": "/auth/sign-up-confirmation?token="
}
}

4 changes: 2 additions & 2 deletions api/apps/api/src/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { ScenarioSpecificationModule } from './modules/scenario-specification';
import { PublishedProjectModule } from '@marxan-api/modules/published-project/published-project.module';
import { BlmValuesModule } from '@marxan-api/modules/blm';
import { AccessControlModule } from '@marxan-api/modules/access-control';
import { FileRepositoryModule } from '@marxan/files-repository';
import { CloningFileSRepositoryModule } from '@marxan/cloning-files-repository';
import { CloneModule } from './modules/clone';

@Module({
Expand Down Expand Up @@ -69,7 +69,7 @@ import { CloneModule } from './modules/clone';
PublishedProjectModule,
BlmValuesModule,
AccessControlModule,
FileRepositoryModule,
CloningFileSRepositoryModule,
CloneModule,
],
controllers: [AppController, PingController],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileRepositoryModule } from '@marxan/files-repository';
import { CloningFileSRepositoryModule } from '@marxan/cloning-files-repository';
import { Module } from '@nestjs/common';
import { TypeOrmModule } from '@nestjs/typeorm';
import { Project } from '../../../projects/project.api.entity';
Expand All @@ -14,7 +14,7 @@ import { TypeormExportRepository } from './typeorm-export.repository';

@Module({
imports: [
FileRepositoryModule,
CloningFileSRepositoryModule,
TypeOrmModule.forFeature([
Project,
ExportEntity,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as archiver from 'archiver';
import { PassThrough } from 'stream';

import { ArchiveLocation } from '@marxan/cloning/domain';
import { FileRepository } from '@marxan/files-repository';
import { CloningFilesRepository } from '@marxan/cloning-files-repository';

import {
ArchiveCreationError,
Expand All @@ -19,14 +19,14 @@ import {
export class NodeArchiveCreator extends ArchiveCreator {
private readonly logger = new Logger(this.constructor.name);

constructor(private readonly fileRepository: FileRepository) {
constructor(private readonly fileRepository: CloningFilesRepository) {
super();
}

async zip(
files: { uri: string; relativeDestination: string }[],
): Promise<Either<ArchiveCreationError, ArchiveLocation>> {
let archivePersistencePromise: ReturnType<FileRepository['save']>;
let archivePersistencePromise: ReturnType<CloningFilesRepository['save']>;
const passThrough = new PassThrough();
const onPersistenceFinished = async (
resolvePromise: (
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileRepository } from '@marxan/files-repository';
import { CloningFilesRepository } from '@marxan/cloning-files-repository';
import { IInferredQueryHandler, QueryHandler } from '@nestjs/cqrs';
import { Either, left } from 'fp-ts/Either';
import { Readable } from 'stream';
Expand All @@ -14,7 +14,7 @@ export class GetArchiveHandler
implements IInferredQueryHandler<GetExportArchive> {
constructor(
private readonly exportRepo: ExportRepository,
private readonly fileRepo: FileRepository,
private readonly fileRepo: CloningFilesRepository,
) {}

async execute({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { GetFileError } from '@marxan/files-repository';
import { GetFileError } from '@marxan/cloning-files-repository';
import { Query } from '@nestjs-architects/typed-cqrs';
import { Either } from 'fp-ts/Either';
import { Readable } from 'stream';
Expand Down
4 changes: 2 additions & 2 deletions api/apps/api/src/modules/clone/export/export.module.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { FileRepositoryModule } from '@marxan/files-repository';
import { CloningFileSRepositoryModule } from '@marxan/cloning-files-repository';
import { Module } from '@nestjs/common';
import { ExportAdaptersModule } from './adapters/export-adapters.module';
import { ExportApplicationModule } from './application/export-application.module';

const ExportApplication = ExportApplicationModule.for([
ExportAdaptersModule,
FileRepositoryModule,
CloningFileSRepositoryModule,
]);

@Module({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileRepositoryModule } from '@marxan/files-repository';
import { CloningFileSRepositoryModule } from '@marxan/cloning-files-repository';
import { Module } from '@nestjs/common';
import { TypeOrmModule } from '@nestjs/typeorm';
import { ImportResourcePieces } from '../application/import-resource-pieces.port';
Expand All @@ -16,7 +16,7 @@ import { TypeormImportRepository } from './typeorm-import.repository.adapter';
ImportComponentEntity,
ImportComponentLocationEntity,
]),
FileRepositoryModule,
CloningFileSRepositoryModule,
],
providers: [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
ExportConfigContent,
exportVersion,
} from '@marxan/cloning/infrastructure/clone-piece-data/export-config';
import { fileNotFound } from '@marxan/files-repository/file.repository';
import { fileNotFound } from '@marxan/cloning-files-repository';
import { FixtureType } from '@marxan/utils/tests/fixture-type';
import { Test } from '@nestjs/testing';
import * as archiver from 'archiver';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileRepositoryModule } from '@marxan/files-repository';
import { CloningFileSRepositoryModule } from '@marxan/cloning-files-repository';
import { Logger, Module, Scope } from '@nestjs/common';
import { CqrsModule } from '@nestjs/cqrs';
import { ApiEventsModule } from '../../../api-events';
Expand Down Expand Up @@ -30,7 +30,7 @@ import { UploadExportFileHandler } from './upload-export-file.handler';
QueueApiEventsModule,
CqrsModule,
ImportAdaptersModule,
FileRepositoryModule,
CloningFileSRepositoryModule,
],
providers: [
PieceImportRequestedSaga,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ArchiveLocation } from '@marxan/cloning/domain';
import { unknownError } from '@marxan/files-repository';
import { unknownError } from '@marxan/cloning-files-repository';
import { Command } from '@nestjs-architects/typed-cqrs';
import { Either } from 'fp-ts/lib/Either';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import { ArchiveLocation } from '@marxan/cloning/domain';
import { FileRepository, unknownError } from '@marxan/files-repository';
import {
CloningFilesRepository,
unknownError,
} from '@marxan/cloning-files-repository';
import { Logger } from '@nestjs/common';
import { CommandHandler, IInferredCommandHandler } from '@nestjs/cqrs';
import { Either, isLeft, left, right } from 'fp-ts/lib/Either';
Expand All @@ -10,7 +13,7 @@ import { UploadExportFile } from './upload-export-file.command';
export class UploadExportFileHandler
implements IInferredCommandHandler<UploadExportFile> {
constructor(
private readonly fileRepository: FileRepository,
private readonly fileRepository: CloningFilesRepository,
private readonly logger: Logger,
) {
this.logger.setContext(UploadExportFileHandler.name);
Expand Down
6 changes: 4 additions & 2 deletions api/apps/api/src/modules/projects/projects.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,14 @@ import {
} from './dto/export.project.dto';
import { ScenarioLockResultPlural } from '@marxan-api/modules/access-control/scenarios-acl/locks/dto/scenario.lock.dto';
import { RequestProjectImportResponseDto } from './dto/import.project.response.dto';
import { unknownError as fileRepositoryUnknownError } from '@marxan/files-repository';
import {
unknownError as fileRepositoryUnknownError,
fileNotFound,
} from '@marxan/cloning-files-repository';
import {
archiveCorrupted,
invalidFiles,
} from '@marxan/cloning/infrastructure/archive-reader.port';
import { fileNotFound } from '@marxan/files-repository/file.repository';
import { ProxyService } from '@marxan-api/modules/proxy/proxy.service';
import { TilesOpenApi } from '@marxan/tiles';
import { mapAclDomainToHttpError } from '@marxan-api/utils/acl.utils';
Expand Down
2 changes: 1 addition & 1 deletion api/apps/api/src/modules/projects/projects.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import {
ChangeProjectRangeErrors,
} from '@marxan-api/modules/projects/blm';
import { UploadExportFile } from '../clone/infra/import/upload-export-file.command';
import { unknownError } from '@marxan/files-repository';
import { unknownError } from '@marxan/cloning-files-repository';
import {
ImportProject,
ImportProjectCommandResult,
Expand Down
16 changes: 8 additions & 8 deletions api/apps/api/test/files-repository/files-repository.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import { Test } from '@nestjs/testing';

import { FixtureType } from '@marxan/utils/tests/fixture-type';
import {
FileRepository,
FileRepositoryModule,
TempStorageRepository,
} from '@marxan/files-repository';
CloningFilesRepository,
CloningFileSRepositoryModule,
VolumeCloningFilesStorage,
} from '@marxan/cloning-files-repository';

let fixtures: FixtureType<typeof getFixtures>;

Expand Down Expand Up @@ -36,12 +36,12 @@ const getFixtures = async () => {
* to avoid communicating with potential storage provider
*/
const app = await Test.createTestingModule({
imports: [FileRepositoryModule],
imports: [CloningFileSRepositoryModule],
})
.overrideProvider(FileRepository)
.useClass(TempStorageRepository)
.overrideProvider(CloningFilesRepository)
.useClass(VolumeCloningFilesStorage)
.compile();
const sut = app.get(FileRepository);
const sut = app.get(CloningFilesRepository);

return {
cleanup: async () => app.close(),
Expand Down
4 changes: 2 additions & 2 deletions api/apps/api/test/jest-e2e.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
"@marxan/projects": "<rootDir>/../../../libs/projects/src",
"@marxan/blm-calibration/(.*)": "<rootDir>/../../../libs/blm-calibration/src/$1",
"@marxan/blm-calibration": "<rootDir>/../../../libs/blm-calibration/src",
"@marxan/files-repository/(.*)": "<rootDir>/../../../libs/files-repository/src/$1",
"@marxan/files-repository": "<rootDir>/../../../libs/files-repository/src",
"@marxan/cloning-files-repository/(.*)": "<rootDir>/../../../libs/cloning-files-repository/src/$1",
"@marxan/cloning-files-repository": "<rootDir>/../../../libs/cloning-files-repository/src",
"@marxan/cloning/(.*)": "<rootDir>/../../../libs/cloning/src/$1",
"@marxan/cloning": "<rootDir>/../../../libs/cloning/src",
"@marxan/webshot/(.*)": "<rootDir>../../../libs/webshot/src/$1",
Expand Down
4 changes: 2 additions & 2 deletions api/apps/api/test/project/get-export-file.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
} from '@marxan-api/modules/clone/export/domain';
import { PublishedProject } from '@marxan-api/modules/published-project/entities/published-project.api.entity';
import { ComponentId, ComponentLocation } from '@marxan/cloning/domain';
import { FileRepository } from '@marxan/files-repository';
import { CloningFilesRepository } from '@marxan/cloning-files-repository';
import { FixtureType } from '@marxan/utils/tests/fixture-type';
import { CommandBus, CqrsModule } from '@nestjs/cqrs';
import { getRepositoryToken } from '@nestjs/typeorm';
Expand Down Expand Up @@ -95,7 +95,7 @@ export const getFixtures = async () => {
eventBusTestUtils.startInspectingEvents();
const commandBus = app.get(CommandBus);
const exportRepo = app.get(ExportRepository);
const fileRepo = app.get(FileRepository);
const fileRepo = app.get(CloningFilesRepository);
const userProjectsRepo = app.get<Repository<UsersProjectsApiEntity>>(
getRepositoryToken(UsersProjectsApiEntity),
);
Expand Down
4 changes: 2 additions & 2 deletions api/apps/api/test/project/get-latest-export.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
} from '@marxan-api/modules/clone/export/domain';
import { PublishedProject } from '@marxan-api/modules/published-project/entities/published-project.api.entity';
import { ComponentId, ComponentLocation } from '@marxan/cloning/domain';
import { FileRepository } from '@marxan/files-repository';
import { CloningFilesRepository } from '@marxan/cloning-files-repository';
import { FixtureType } from '@marxan/utils/tests/fixture-type';
import { CommandBus, CqrsModule } from '@nestjs/cqrs';
import { getRepositoryToken } from '@nestjs/typeorm';
Expand Down Expand Up @@ -100,7 +100,7 @@ export const getFixtures = async () => {
const eventBusTestUtils = app.get(EventBusTestUtils);
const commandBus = app.get(CommandBus);
const exportRepo = app.get(ExportRepository);
const fileRepo = app.get(FileRepository);
const fileRepo = app.get(CloningFilesRepository);
const userProjectsRepo = app.get<Repository<UsersProjectsApiEntity>>(
getRepositoryToken(UsersProjectsApiEntity),
);
Expand Down
11 changes: 7 additions & 4 deletions api/apps/api/test/utils/api-application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { AppModule } from '@marxan-api/app.module';
import { ProjectChecker } from '@marxan-api/modules/projects/project-checker/project-checker.service';
import { QueueBuilder } from '@marxan-api/modules/queue/queue.builder';
import {
FileRepository,
TempStorageRepository,
} from '@marxan/files-repository';
CloningFilesRepository,
VolumeCloningFilesStorage,
} from '@marxan/cloning-files-repository';
import { INestApplication, ValidationPipe } from '@nestjs/common';
import { ModuleMetadata } from '@nestjs/common/interfaces/modules/module-metadata.interface';
import { Test, TestingModuleBuilder } from '@nestjs/testing';
Expand All @@ -29,7 +29,10 @@ const defaultOverrides: Overrides = {
{ provider: QueueBuilder, implementation: FakeQueueBuilder },
{ provider: ProjectChecker, implementation: ProjectCheckerFake },
{ provider: ScenarioChecker, implementation: ScenarioCheckerFake },
{ provider: FileRepository, implementation: TempStorageRepository },
{
provider: CloningFilesRepository,
implementation: VolumeCloningFilesStorage,
},
{
provider: ScenarioCalibrationRepo,
implementation: FakeScenarioCalibrationRepo,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
"sharedFileStorage": {
"localPath": "API_SHARED_FILE_STORAGE_LOCAL_PATH",
"cleanupTemporaryFolders": "BACKEND_CLEANUP_TEMPORARY_FOLDERS"
},
"cloningFileStorage": {
"localPath": "CLONING_FILE_STORAGE_LOCAL_PATH"
}
},
"fileUploads": {
Expand Down
5 changes: 4 additions & 1 deletion api/apps/geoprocessing/config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"host": "marxan-redis",
"port": 6379,
"password": null,
"concurrency" : 50
"concurrency": 50
},
"postgresApi": {
"url": null,
Expand Down Expand Up @@ -38,6 +38,9 @@
"sharedFileStorage": {
"localPath": "/tmp/storage",
"cleanupTemporaryFolders": true
},
"cloningFileStorage": {
"localPath": "/opt/marxan-project-cloning"
}
},
"fileUploads": {
Expand Down
Loading