Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(front): add BLM screenshots to calibration results[MARXAN-1416] #960

Merged
merged 7 commits into from
Apr 12, 2022

Conversation

anamontiaga
Copy link
Collaborator

@anamontiaga anamontiaga commented Apr 6, 2022

Add BLM screenshots to calibration results

Testing instructions

  1. Set NEXT_PUBLIC_URL=https://marxan-git-feature-screenshot-map-vizzuality1.vercel.app in your local env.
  2. Generate a new calibration and click on one of the BLM values ​​proposed in the chart.
  3. The image should appear on the far right of the chart and should correspond to that chosen BLM value.

Important: The same image will be displayed for all values ​​because the correct image is not yet working in marxan49 (update is missing).

Feature relevant tickets

MARXAN-1416


Checklist before submitting

  • Please uncomment NEXT_PUBLIC_URL on saveScenarioCalibrationRange baseUrl before merging in develop.

@anamontiaga anamontiaga added Frontend Everything related frontend Ready to review PR ready to review labels Apr 6, 2022
@vercel
Copy link

vercel bot commented Apr 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/2rEq14Q4oD52EGuQAP5fYev22Ruh
✅ Preview: https://marxan-git-feat-frontmarxan-1416-blm-screenshots-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/HK9WYVniNNRgiwE57zzK2YpwtCtL
✅ Preview: https://marxan-storybook-git-feat-frontmarxan-1416-b-bee99c-vizzuality1.vercel.app

return SCENARIOS.request({
url: `/${id}/calibration`,
const saveScenarioCalibrationRange = ({ sid, data }: SaveScenarioCalibrationRangeProps) => {
const baseUrl = /* process.env.NEXT_PUBLIC_URL || */ window.location.origin;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily disabled. Remember to uncomment before merging in develop.

@anamontiaga anamontiaga requested a review from mbarrenechea April 6, 2022 17:54
@mbarrenechea mbarrenechea merged commit cf9114a into develop Apr 12, 2022
@mbarrenechea mbarrenechea deleted the feat/front/MARXAN-1416-blm-screenshots branch April 12, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Don't merge Frontend Everything related frontend Ready to review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants