Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct blue water footprint calculations #988

Conversation

elpamart
Copy link
Contributor

General description

This PR contains the following:

  • Review of the water use and unsustainable water use formulas. This ended up in fixing a matching HS code issues and adding more admin levels for the blue water footprint indicators coefficient data ingestion.
  • Review of the current deforestation and carbon formulas. I have updated these formulas in a separate notebook that we can review together and discuss improvements.

Testing instructions

For the indicator coefficient data ingestion:

  • check that the indicators coefficient data ingestion works successfully
  • make sure that the indicator coefficient HScode attributed is ingested as text
  • make sure that the indicator coefficient hs code and materials hscode have a successful match (the materialId in the indicators coefficient entity has to be always filled in)

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
landgriffon-client ⬜️ Ignored (Inspect) Jun 19, 2023 6:42am
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Jun 19, 2023 6:42am

@elpamart elpamart requested a review from alexeh June 22, 2023 07:20
@alexeh alexeh merged commit bb150d6 into dev Jun 23, 2023
@alexeh alexeh deleted the LANDGRIF-1406-review-indicator-formulas-already-applied-in-the-stored-procedures branch July 24, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants