Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: removes next-env.d.ts #917

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Dockerfile: removes next-env.d.ts #917

merged 1 commit into from
Mar 14, 2023

Conversation

agnlez
Copy link
Member

@agnlez agnlez commented Mar 14, 2023

General description

Removes copy of next-env.d.ts from Dockerfile.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Provide minimal instructions on how to test this PR.

  • Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@agnlez agnlez self-assigned this Mar 14, 2023
@vercel
Copy link

vercel bot commented Mar 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 9:22AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Mar 14, 2023 at 9:22AM (UTC)

@agnlez agnlez marked this pull request as draft March 14, 2023 09:12
@agnlez agnlez force-pushed the fix/client/docker branch from f22290c to 6542f75 Compare March 14, 2023 09:13
@agnlez agnlez force-pushed the fix/client/docker branch from 79dacf8 to d699fe6 Compare March 14, 2023 09:18
@agnlez agnlez marked this pull request as ready for review March 14, 2023 09:58
@agnlez agnlez requested a review from davidsingal March 14, 2023 09:59
@davidsingal davidsingal merged commit b5e8134 into dev Mar 14, 2023
@davidsingal davidsingal deleted the fix/client/docker branch March 14, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsingal davidsingal Awaiting requested review from davidsingal

Assignees

@agnlez agnlez

Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agnlez @davidsingal