Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort table data by year #909

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Sort table data by year #909

merged 2 commits into from
Mar 8, 2023

Conversation

barbara-chaves
Copy link
Contributor

@barbara-chaves barbara-chaves commented Mar 7, 2023 •
edited
Loading

General description

This PR adds the functionality of sorting by year on analysis table

Designs

Design

Testing instructions

  • Sort actual data impact by year
  • Sort data compared with other scenario by year

Checklist before merging

  • Branch name / PR includes the related Jira ticket Id.
  • Tests to check core implementation / bug fix added.
  • All checks in Continuous Integration workflow pass.
  • Feature functionally tested by reviewer(s).
  • Code reviewed by reviewer(s).
  • Documentation updated (README, CHANGELOG...) (if required)

@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
landgriffon-client ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 8, 2023 at 8:46AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
landgriffon-cookie-traceability ⬜️ Ignored (Inspect) Mar 8, 2023 at 8:46AM (UTC)

@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-956-sort-table-data-by-year branch from 1fb8493 to 36692ac Compare March 7, 2023 11:57
@barbara-chaves barbara-chaves self-assigned this Mar 7, 2023
@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-956-sort-table-data-by-year branch from 36692ac to e2bacb3 Compare March 7, 2023 15:58
@barbara-chaves barbara-chaves marked this pull request as ready for review March 7, 2023 16:25
@barbara-chaves barbara-chaves requested a review from agnlez March 7, 2023 16:31
@barbara-chaves
Add sorting by year to analysis table
96fc79e 
Add changelog

Add tests

Fix tests
agnlez
agnlez approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@agnlez agnlez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just fix the conflict in tests, please 🙏🏻

@barbara-chaves barbara-chaves force-pushed the client/feature/LANDGRIF-956-sort-table-data-by-year branch from e2bacb3 to 96fc79e Compare March 7, 2023 17:36
@davidsingal davidsingal changed the title Client/feature/landgrif 956 sort table data by year Sort table data by year Mar 8, 2023
@davidsingal davidsingal merged commit fe2315c into dev Mar 8, 2023
@davidsingal davidsingal deleted the client/feature/LANDGRIF-956-sort-table-data-by-year branch March 8, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnlez agnlez agnlez approved these changes

@davidsingal davidsingal Awaiting requested review from davidsingal

Assignees

@barbara-chaves barbara-chaves

Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barbara-chaves @agnlez @davidsingal