Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken override for payment methods #64

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

tatarincev
Copy link
Collaborator

@tatarincev tatarincev commented Mar 8, 2025

Description

Breaking changes.
When overriding the payment method while preserving the base method name, the new payment method type name is used and old type name is not used anymore. This commit fixes the issue.
Example of code that override the payment method with preserve the base method name:

  AbstractTypeFactory<PaymentMethod>.OverrideType<SkyflowPaymentMethod, OpusSkyflowPaymentMethod>()
                                   .WithFactory(() => appBuilder.ApplicationServices.GetService<OpusSkyflowPaymentMethod>())
                                   .WithTypeName(nameof(SkyflowPaymentMethod));

References

QA-test:

Jira-link:

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Payment_3.807.0-pr-64-b199.zip

@vc-ci
Copy link
Contributor

vc-ci commented Mar 8, 2025

Reveiw task created: https://virtocommerce.atlassian.net/browse/VCST-2853

Copy link

sonarqubecloud bot commented Mar 8, 2025

Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.703
Timestamp: 08-03-2025T15:00:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants