Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCST-1399: Add CatalogSeoResolver and related tests and helpers #768

Merged
merged 10 commits into from
Feb 4, 2025
Merged

VCST-1399: Add CatalogSeoResolver and related tests and helpers #768

merged 10 commits into from
Feb 4, 2025

Conversation

OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Jan 29, 2025 •
edited by vc-ci
Loading

Description

feat: Add CatalogSeoResolver and related tests and helpers.

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-1399

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Catalog_3.840.0-pr-768-a9e1.zip

vc-ci
vc-ci reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.294
Timestamp: 29-01-2025T16:20:19

vc-ci
vc-ci reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.924
Timestamp: 29-01-2025T16:55:39

vc-ci
vc-ci reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.968
Timestamp: 29-01-2025T17:22:29

vc-ci
vc-ci reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.542
Timestamp: 29-01-2025T19:06:27

vc-ci
vc-ci reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.671
Timestamp: 29-01-2025T19:21:30

vc-ci
vc-ci reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.424
Timestamp: 30-01-2025T08:05:41

vc-ci
vc-ci reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.943
Timestamp: 30-01-2025T10:25:47

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 31, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
5 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vc-ci
vc-ci reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.914
Timestamp: 31-01-2025T15:48:37

@OlegoO OlegoO merged commit 36588c6 into dev Feb 4, 2025
6 checks passed
@OlegoO OlegoO deleted the feat/VCST-1399 branch February 4, 2025 09:33
OlegoO added a commit that referenced this pull request Feb 4, 2025
@OlegoO
feat: Add CatalogSeoResolver and related tests and helpers (#768)
62947ea
OlegoO added a commit that referenced this pull request Feb 4, 2025
@OlegoO
feat: Add CatalogSeoResolver and related tests and helpers (#768)
4ce9422
OlegoO added a commit that referenced this pull request Feb 4, 2025
@OlegoO
feat: Add CatalogSeoResolver and related tests and helpers (#768)
b03df2c
OlegoO added a commit that referenced this pull request Feb 4, 2025
@OlegoO
Revert "feat: Add CatalogSeoResolver and related tests and helpers (#768
45bec05 
)"

This reverts commit b03df2c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vc-ci vc-ci vc-ci left review comments

@Ljutyj Ljutyj Ljutyj approved these changes

@artem-dudarev artem-dudarev Awaiting requested review from artem-dudarev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegoO @vc-ci @Ljutyj