Ensure that saved editorial reviews are not marked as inherited #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reveiw task created: https://virtocommerce.atlassian.net/browse/VCST-1196 |
OlegoO
approved these changes
May 8, 2024
artem-dudarev
requested changes
May 9, 2024
src/VirtoCommerce.CatalogModule.Web/Scripts/blades/editorialReview-detail.js
Outdated
Show resolved
Hide resolved
src/VirtoCommerce.CatalogModule.Web/Scripts/blades/editorialReview-detail.js
Show resolved
Hide resolved
artem-dudarev
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I have a product variation that inherit reviews (descriptions) from the parent, these reviews are editable, but the edits won't get persisted in the database - they get silently dropped without a warning. This behavior is due to the fact that those edited inherited reviews are ignored when mapping
CatalogProducttoItemService- there's a filter onEditorialReview.IsInheritedproperty.This PR offers a small change in the UI code, that clears the
isInheritedflag on those editorial reviews that got saved, effectively promoting them to variation's own reviews. In effect, the user can now directly override inherited reviews in variants.