Dev #5
Merged
Dev #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated copyright
andrii-iakovenko
previously approved these changes
Jan 17, 2020
…atchetClient, SecureChatContext, travis build setup
| @@ -265,7 +265,7 @@ class KeysRotatorTest { | |||
| return false | |||
| } | |||
| storedOneTimeKeysIds.forEachIndexed { i, value -> | |||
| if (!cloudOneTimeKeysIds[i].contentEquals(value)) { | |||
| if (!cloudOneTimeKeysIds[i]!!.contentEquals(value)) { | |||
There was a problem hiding this comment.
Maybe we should check a cloud key existing?
| @@ -563,7 +559,7 @@ class SecureChat { | |||
| ) | |||
| } | |||
|
|
|||
| if (!ratchetMessage.sessionId.contentEquals(sessionId)) { | |||
| if (!ratchetMessage.sessionId!!.contentEquals(sessionId)) { | |||
There was a problem hiding this comment.
RatchetGroupMessage could be created with a default constructor and passed to this method. In this case process would be failed. Let's check sessionId is not null
There was a problem hiding this comment.
sessionId is a mandatory property? should we throw a NullArgumentException or smth if it's null?
There was a problem hiding this comment.
I would throw IllegalArgumentException
| file.delete() | ||
|
|
||
| val deleted = file.delete() | ||
| if (!deleted) throw FileDeletionException() |
There was a problem hiding this comment.
Let's add file name to exception message
andrii-iakovenko
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.