Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hours can have a "or" in them. #127

Merged
merged 5 commits into from
Jun 8, 2021
Merged

Conversation

NishchintDhawan
Copy link

@NishchintDhawan NishchintDhawan commented Jun 1, 2021

Fix for the issue #119: Hours can have a "or" in them.

Copy link
Member

@aomi aomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Some general notes.

  • You have to add spaces between the linked issue in the description or it won't link properly.
  • Avoid using var given it isn't required and we try to use const and let wherever we can.
  • Please remove any commented code prior to submitting your PR.
  • Please use camelCase instead of under_score for function names and variables.

@aomi aomi linked an issue Jun 2, 2021 that may be closed by this pull request
Copy link
Collaborator

@keithradford keithradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but there's some general formatting that needs to be addressed to keep things consistent with the rest of the codebase. Running npm run lint:fix should address most if not all of them

Copy link
Collaborator

@keithradford keithradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

Copy link
Collaborator

@keithradford keithradford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hours can have a "or" in them
3 participants