-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Hours can have a "or" in them. #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Some general notes.
- You have to add spaces between the linked issue in the description or it won't link properly.
- Avoid using
var
given it isn't required and we try to useconst
andlet
wherever we can. - Please remove any commented code prior to submitting your PR.
- Please use
camelCase
instead ofunder_score
for function names and variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but there's some general formatting that needs to be addressed to keep things consistent with the rest of the codebase. Running npm run lint:fix
should address most if not all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fix for the issue #119: Hours can have a "or" in them.