Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract course title from Class Schedule Listings page and Details Course Info page #131

Closed
aomi opened this issue Jun 19, 2021 · 1 comment
Closed

Extract course title from Class Schedule Listings page and Details Course Info page #131

aomi opened this issue Jun 19, 2021 · 1 comment
Assignees
@NishchintDhawan
Labels
feature New feature or request

Comments

@aomi
Copy link
Member

aomi commented Jun 19, 2021

As mentioned VikeLabs/courseup#220, topic courses have their titles not in the calendar. We didn't initially scrape this as we assumed the title would be the same. Clearly this assumption was wrong.

Add a title attribute to the respective types/interfaces. and add the parser code in the appropriate files (likely under the src/pages/courseListingEntries and src/pages/detailedClassInformation within the extractor function already there.

Parsing the title should not contain extra info like the CRN etc. The example of this in action would be:
Before Parsing:

TOPICS:SOFTWARE ENGINEER: Quantum Algorithms and Software Engineering - 32729 - SENG 480C - A01

Parsed:

TOPICS:SOFTWARE ENGINEER: Quantum Algorithms and Software Engineering
@aomi aomi added the feature New feature or request label Jun 19, 2021
@aomi aomi assigned aomi and unassigned aomi Jun 19, 2021
@NishchintDhawan
Copy link

Sounds good.

@NishchintDhawan NishchintDhawan mentioned this issue Sep 4, 2021
Merged
aomi pushed a commit that referenced this issue Sep 14, 2021
@NishchintDhawan
Fix for Issue #131: Extract course title from Class Schedule Listings…
ca4f857 
… page and Details Course Info page. (#137)

* Fix: Hours can have a 'or' in them

* Updated fix

* updated chenges after review

* update formatting

* updated catalog.ts

* extract course title in detailedClassInformation

* fix missing tests for detailClassInformation

* fixing failing tests

* fix initialization for title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NishchintDhawan NishchintDhawan

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aomi @NishchintDhawan @keithradford