Fix update date / Optimize cache #1875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
barijaona
commented
Mar 11, 2025
•
barijaona
commented
- Provides a much snappier user interface : prevent some temporary locks when we have simultaneously feed refresh and user selecting a feed
- Fix dates of year 1969 or 1970 in "Last Udpate" column (issue Articles showing dummy date of 12/31/1969 in "Last Update" column #1832)
barijaona
force-pushed
the
folderCache
branch
3 times, most recently
from
0ff2653 to
48cb06a
Compare
barijaona
changed the title
barijaona
force-pushed
the
folderCache
branch
2 times, most recently
from
9af7535 to
67a2e43
Compare
|
I apologize for multiple force pushes I have done to fix my errors. |
in `-updateArticle:ofFolder:withArticle:`, `existingArticle` may be an incomplete version originating from `-minimalCacheForFolder:`, and may therefore have neither `lastUpdate` nor `publicationDate` To calculate the new last update date, we reproduce the date logic which exists in -addArticle:toFolder: Fix date 1.1.1970 or 31.12.1969 appearing in "Last Update" column Issue ViennaRSS#1832
barijaona
force-pushed
the
folderCache
branch
2 times, most recently
from
750dded to
8710a06
Compare
We avoid systematically resetting isCached status in order to allow article addition (which requires ensureCache) to occur even when we try to display the folder. Also : remove @synchronize's which are redundant with -getCompleteArticles' ones.
Lessen memory requirement: these enclosure informations will be required (and retrieved from database) only when we display articles of folder. Minimal cache is only used as a proxy marking if an article is (or isn't) present in database, (un)read, (un)flagged, (un)deleted or revised.
As suggested by @TAKeanice's comment in issue ViennaRSS#1832 ViennaRSS#1832 (comment) However, handle the case where the title of an article is changed, and the updated article is pushed with a new publication date, while the `guid` value reveals that it is in fact an update of a preexisting article.
Correct messages with last update date of 1.1.1970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.