patch: pr8293 #8294
Merged
patch: pr8293 #8294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
inomdzhon
commented
Feb 19, 2025
inomdzhon
commented
- patch fix(HorizontalScroll): remove wheels event from container #8293
- reverts #7882, #8177 h2. Описание В **Firefox** событие `onwheel` на контейнере и одновременная прокрутка скроллируемого элемента (`scrollBy` или `scrollLeft`) **тач-падом** негативно влияет на перерисовку контента во время скролла. Чтобы решить проблему #7774, можно навесить `onwheel` на каждую из стрелок навигации, но у этого решения есть свой баг: если начать крутить колесо с сначала или конца, то появление стрелки навигации заблоркирует прокрутку, то тех пор пока не двинешь мышкой над ней, чтобы началась обработка события `onwheel` на стрелке. Из-за этих проблем оптимальным будет откатить фикс #7774 и пометить его как **Won't Fix**. Это будет являться ограничением компонента. Тестировалось на версиях **Firefox** `134` и `135`. Наблюдается с `v6.7.4` до `v7.1.1` при передаче `scrollOnAnyWheel`, а с `v7.1.2` всегда (связано с #8177). https://github.com/user-attachments/assets/008907de-e6bd-4807-bbea-b0e7f69a8605 h2. Release notes h2. Исправления - HorizontalScroll: отменён фикс #7774 из-за проблем перерисовок в **Firefox** при прокрутке через тач-пад, теперь невозможность прокрутить колесом мыши над стрелкой навигации будет считаться ограничением компонента
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 414c3bb |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.1-stable #8294 +/- ##
===========================================
Coverage 95.58% 95.58%
===========================================
Files 397 397
Lines 11364 11367 +3
Branches 3757 3755 -2
===========================================
+ Hits 10862 10865 +3
Misses 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EldarMuhamethanov
approved these changes
Feb 19, 2025
BlackySoul
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.