Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Gallery): remove add slide change animation to queue at not looped #8292

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Feb 18, 2025


  • Unit-тесты
  • Release notes

Описание

В #8042 реализации зацикленной и незацикленной галерии были объединены. При объединении была изменена логика перелистывания слайдов при изменении slideIndex. В новой реализации перелистывание происходило с помощью очереди анимаций. Поэтому при быстром изменении slideIndex создается не очень хорошее ощущение, что слайды перелистываются заторможено. Поэтому нужно для незацикленной галереи сделать перелистывание без использования очереди анимаций

Изменения

Убрал анимацию через js и добавление ее в очередь при перелистывании слайдов в незацикленной галерее.

Release notes

Исправления

  • Gallery: Поправлено перелистывание слайдов при быстром изменении slideIndex

@EldarMuhamethanov EldarMuhamethanov added this to the v7.1.3 milestone Feb 18, 2025
@EldarMuhamethanov EldarMuhamethanov self-assigned this Feb 18, 2025
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner February 18, 2025 14:41
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Feb 18, 2025
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 397.03 KB (-0.01% 🔽)
JS (gzip) 120.58 KB (-0.01% 🔽)
JS (brotli) 99.17 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.58 KB (0%)
CSS (gzip) 43.16 KB (0%)
CSS (brotli) 34.47 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 653f453

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (c708d03) to head (653f453).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8292      +/-   ##
==========================================
- Coverage   95.54%   95.54%   -0.01%     
==========================================
  Files         404      404              
  Lines       11641    11637       -4     
  Branches     3859     3859              
==========================================
- Hits        11122    11118       -4     
  Misses        519      519              
Flag Coverage Δ
unittests 95.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 9d3d3d9 into master Feb 19, 2025
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/fix-perform-slide-change-not-looped branch February 19, 2025 11:06
@vkcom-publisher
Copy link
Contributor

v7.1.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:gallery patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants