Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: pr8266 #8290

Merged
merged 1 commit into from
Feb 18, 2025
Merged

patch: pr8266 #8290

merged 1 commit into from
Feb 18, 2025

Conversation

andrey-medvedev-vk
Copy link
Contributor

@andrey-medvedev-vk
fix(Alert): Move dismiss button before actions to focus on it first (#…
caa2d33 
…8266)

Кнопка закрытия, при наличии, первой получает фокус при открытии алерта
В документацию по доступности компонента добавлен пункт по поводу имен кнопок с одинаковыми действиями
# Conflicts:
#	packages/vkui/src/components/Alert/Readme.md
@andrey-medvedev-vk andrey-medvedev-vk requested a review from a team as a code owner February 18, 2025 09:50
@andrey-medvedev-vk andrey-medvedev-vk self-assigned this Feb 18, 2025
@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 390.32 KB (0%)
JS (gzip) 118.45 KB (-0.01% 🔽)
JS (brotli) 97.53 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 343.12 KB (0%)
CSS (gzip) 42.44 KB (0%)
CSS (brotli) 33.86 KB (0%)

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit caa2d33

@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (5ec41e7) to head (caa2d33).
Report is 1 commits behind head on 7.1-stable.

Additional details and impacted files 
@@             Coverage Diff             @@
##           7.1-stable    #8290   +/-   ##
===========================================
  Coverage       95.58%   95.58%           
===========================================
  Files             397      397           
  Lines           11368    11368           
  Branches         3757     3757           
===========================================
  Hits            10866    10866           
  Misses            502      502
Flag Coverage Δ
unittests 95.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-medvedev-vk andrey-medvedev-vk merged commit d56bb04 into 7.1-stable Feb 18, 2025
29 checks passed
@andrey-medvedev-vk andrey-medvedev-vk deleted the patch/pr8266 branch February 18, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackySoul BlackySoul BlackySoul approved these changes

@EldarMuhamethanov EldarMuhamethanov EldarMuhamethanov approved these changes

Assignees

@andrey-medvedev-vk andrey-medvedev-vk

Labels
None yet
Projects
VKUI
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrey-medvedev-vk @BlackySoul @EldarMuhamethanov