feat(HorizontalScroll, CardScroll): fix rtl view #8110
+237
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit e876349 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8110 +/- ##
==========================================
- Coverage 95.46% 95.43% -0.03%
==========================================
Files 406 406
Lines 11610 11630 +20
Branches 3844 3854 +10
==========================================
+ Hits 11083 11099 +16
- Misses 527 531 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vkcom-publisher
added
the
pr-needs-work
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
EldarMuhamethanov
removed
the
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
vkcom-publisher
removed
the
pr-needs-work
# Conflicts: # packages/vkui/src/components/CardScroll/CardScroll.test.tsx # packages/vkui/src/components/CardScroll/CardScroll.tsx # packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
vkcom-publisher
added
the
pr-needs-work
vkcom-publisher
removed
the
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
EldarMuhamethanov
removed
the
pr-needs-work
# Conflicts: # packages/vkui/src/components/HorizontalScroll/HorizontalScroll.test.tsx # packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
inomdzhon
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас компонент
HorizontalScrollработает неправильно вrtl, а с ним вместе соответственно компонентCardScrollтоже работает некорректноИзменения
HorizontalScrollв режимеrtlCardScrollв режимеrtlRelease notes
Улучшения
rtlrtl